showing more info on the request panel #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ('cache_control', None, None), | ||
| ('context', None, None), | ||
| ('current_route_path', None, True), | ||
| ('current_route_url', None, True), |
There was a problem hiding this comment.
Remove these method calls and support for the is_execute_method please. 1) These 2 methods don't work when traversal is used and 2) these values are acquirable without using the methods (request.url and request.path if I remember right).
There was a problem hiding this comment.
Makes sense. Done.
The API docs for those 2 items should probably reference this with something like "If you simply want to read the current value, you might just want to use X".
This was referenced Feb 26, 2017
This was referenced Mar 12, 2017
This was referenced Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #209