Merge pull request #285 from mmerickel/fix-panel-id-tag

remove extra id="${panel.dom_id}" tags in history the tab
Pylons · Apr 21, 2017 · 494fa52 · 494fa52
2 parents b9366bf + b650968
commit 494fa52
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -28,6 +28,10 @@ Unreleased
   your application's ``BeforeRender`` subscribers.
   See https://github.com/Pylons/pyramid_debugtoolbar/pull/284
 
+- Remove duplicate ``id="${panel.dom_id}"`` tags in history tab html. Only
+  the top-level ``<li>`` tag has the id now.
+  See https://github.com/Pylons/pyramid_debugtoolbar/pull/285
+
 3.0.5 (2016-11-1)
 -----------------
 

diff --git a/pyramid_debugtoolbar/templates/history_tab.dbtmako b/pyramid_debugtoolbar/templates/history_tab.dbtmako
@@ -21,12 +21,10 @@
           <li class="${_css_class}" id="${panel.dom_id}">
             % if panel.has_content:
             <a href="${panel.url or '#'}" 
-              title="${panel.title}" 
-              id="${panel.dom_id}">
+              title="${panel.title}">
               % else:
               <a href="${panel.url or '#'}"
                 title="${panel.title}"
-                id="${panel.dom_id}"
                 class="contentless">
                 % endif