Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-joined error messages. #253

Merged
merged 3 commits into from
Feb 24, 2016

Conversation

gjo
Copy link
Contributor

@gjo gjo commented Feb 19, 2016

colander.Invalid:asdict returns field's error messages as a single string joined with '; ' now.
this patch allows optional separators to user,
and if it supplied None it returns pre-joined messages as list of string.

…t`, if not supplied return list of string instead of single string.
@gjo
Copy link
Contributor Author

gjo commented Feb 23, 2016

CI build failed on Python 3.2.
But it's no problem because pip 8.0 that used on CI droped python 3.2 support.
https://github.com/pypa/pip/blob/develop/CHANGES.txt

Can I edit tox.ini, too?

@digitalresistor
Copy link
Member

Please merge master into your branch, and push to this PR.

Thanks.

* master:
  Sign contributors
  Ignore the new files tox creates
  Simplify tox by adding py-cover
  Don't try and build on Py32 on Travis
  Remove Python 3.2 classifier
  Remove Python 3.2 support
@gjo
Copy link
Contributor Author

gjo commented Feb 24, 2016

Done.
Thank you @bertjwregeer

@mmerickel
Copy link
Member

LGTM. Please add a note to the changelog referencing this PR and add your name to the CONTRIBUTORS.txt.

@gjo
Copy link
Contributor Author

gjo commented Feb 24, 2016

I was already added my name to CONTRIBUTORS.txt:124.
Thank you.

mmerickel added a commit that referenced this pull request Feb 24, 2016
@mmerickel mmerickel merged commit 46177b9 into Pylons:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants