Fix issue #2, fix inter-field message extraction, add asdict2(), fix All() so it won't lose children exceptions #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and on next commit we fix it.
...but I have another test case (see next commit).
...don't need it to be interactive anymore.
...validation and message assignment.
asdict() returns one item per leaf of the exception graph. That does not cover my use case, which is not unlike http://deformdemo.repoze.org/interfield/ So asdict2() returns more items in the dictionary, allowing you to place error messages in more places of your form. Originally I intended to replace the behaviour of asdict(), but in so doing I broke 4 other test cases, so I expect this kind of change has to be made on a new API. Thus, asdict2().
This commit contains only the test, see next commit for the fix.
Also removed the funny but non functional Texas locale.
|
Sorry I didn't get to this for Colander 0.9.3 (just released). I'll review it for the next version. |
|
I had this same problem, and solved by replacing Also, this requires some modifications on deform. I'll try to send you a patch later. |
|
I am OK with whatever implementation details as long as the tests I added pass... |
|
Is this going to be merged into 0.9.4? I didnt't send the stuff I commented before because it wasn't necessary. In the end my solution was very close to nando's one. I hope it gets included in 0.9.4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All with tests demonstrating the purpose of the edits.
Oh, and update the Brazilian Portuguese translation.