-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email validator does not allow double hyphen #283
Comments
In fixing this for our project I opted to use an email regex taken from Chrome based on the HTML specs, on the basis that pattern is widely used and is pretty simple. Would this be accepted upstream? |
I'd be willing to accept that regex. Since that is what the browser is using for validation. |
digitalresistor
added a commit
that referenced
this issue
Feb 1, 2019
This is the original case that prompted the ticket/change in #283.
Merged
digitalresistor
added a commit
that referenced
this issue
Feb 1, 2019
This is the original case that prompted the ticket/change in #283.
seanh
added a commit
to hypothesis/h
that referenced
this issue
May 17, 2019
This is no longer necessary since Colander 1.7.0 changed its default email regex to match the one from the WhatWG HTML spec. See: * 759e0b9 * Pylons/colander#324 * Pylons/colander#283
seanh
added a commit
to hypothesis/h
that referenced
this issue
Jun 4, 2019
This is no longer necessary since Colander 1.7.0 changed its default email regex to match the one from the WhatWG HTML spec. See: * 759e0b9 * Pylons/colander#324 * Pylons/colander#283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
lorem@i--ipsum.com
is a valid email address but the current email validator doesn't validate it.Here's an email validator that I wrote with code that I stole from Django which works:
The text was updated successfully, but these errors were encountered: