Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up files and utils #460

Merged
merged 4 commits into from
Oct 11, 2021
Merged

chore: clean up files and utils #460

merged 4 commits into from
Oct 11, 2021

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Oct 11, 2021

Description

  • clean unecessary files from ./genesis/ dir
  • remove unused variables and targets from Makefile
  • make Makefile more in line with Cosmos SDK Makefile
  • set VERSION when running go test based targets

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aljo242 aljo242 requested a review from a user October 11, 2021 15:00
@aljo242 aljo242 self-assigned this Oct 11, 2021
@aljo242 aljo242 merged commit 427e8d9 into develop Oct 11, 2021
@aljo242 aljo242 deleted the chores branch October 11, 2021 15:38
aljo242 pushed a commit that referenced this pull request Oct 18, 2021
* docs: write spec (#406)

* start spec writing

* table formatting

* parameters

* state

* spec v1

* add new pages to contents

* concepts

* starting client

* cli

* client doc

* basic improvements

* direct editorial changes and comments for first review cycle

* address feedback

Co-authored-by: aljo242 <amj92@pitt.edu>
Co-authored-by: Barrie Byron <barriebyron.barriebyron@gmail.com>

* adding updated config.yml (#458)

* fix gentx issue

* clean up genesis folder

* chore: clean up files and utils (#460)

* clean up genesis folder

* clean up makefiles

* set version for tests

* add build-reproducible target

* fix Makefile typo

* chore: sdk upgrade (#463)

* upgrade cosmos sdk and ibc-go

Co-authored-by: aljo242 <amj92@pitt.edu>
Co-authored-by: Barrie Byron <barriebyron.barriebyron@gmail.com>
Co-authored-by: Emeka O Onwuliri <conwuliri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant