Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update code to starport v0.18 compliance #428

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Sep 28, 2021

Description

Follows the migration guide for upgrading a starport scaffolded chain to v0.18.0 compliance.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aljo242 aljo242 added the enhancement New feature or request label Sep 28, 2021
@aljo242 aljo242 self-assigned this Sep 28, 2021
@aljo242 aljo242 requested a review from a user September 28, 2021 13:56
@aljo242 aljo242 merged commit c6daa1d into develop Sep 28, 2021
@aljo242 aljo242 deleted the aljo242/starport-v0.18 branch September 28, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant