Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on_member_update in event reference docs #932

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Update on_member_update in event reference docs #932

merged 1 commit into from
Feb 6, 2022

Conversation

argo0n
Copy link
Contributor

@argo0n argo0n commented Feb 5, 2022

Warning: We have a feature freeze till release

That means we won't accept new features for now. Only bug fixes.

Summary

If a user is given a timeout, this is captured by on_member_update, so it should reflect in the docs to avoid people being confused as to whether on_member_update is called when a user is given/no longer has a timeout

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@argo0n
Copy link
Contributor Author

argo0n commented Feb 5, 2022

I believe discord.AuditLogAction.member_update needs to be edited too, not sure how to edit that one though
image

@Lulalaby Lulalaby enabled auto-merge (rebase) February 5, 2022 10:26
@Lulalaby Lulalaby added this to the v2.0 milestone Feb 5, 2022
@Lulalaby Lulalaby merged commit d1e1670 into Pycord-Development:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants