Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type hint Sink.vc #919

Merged
merged 5 commits into from
Feb 4, 2022
Merged

feat: type hint Sink.vc #919

merged 5 commits into from
Feb 4, 2022

Conversation

VincentRPS
Copy link
Member

Summary

Type hints Sink.vc to the VoiceChannel class.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@VincentRPS VincentRPS self-assigned this Feb 4, 2022
@VincentRPS VincentRPS added feature Implements a feature Merge normally priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Feb 4, 2022
@VincentRPS VincentRPS added this to the v2.0 milestone Feb 4, 2022
krittick
krittick reviewed Feb 4, 2022
View reviewed changes
discord/sinks/core.py Outdated Show resolved Hide resolved
VincentRPS and others added 2 commits February 4, 2022 15:20
@VincentRPS @krittick
chore: fix typing
ea780c5 
Co-authored-by: krittick <ben@krittick.net>
@VincentRPS
fix: conflicts
2857ae6
krittick
krittick previously approved these changes Feb 4, 2022
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (squash) February 4, 2022 07:30
@Lulalaby Lulalaby merged commit 8fbd374 into Pycord-Development:master Feb 4, 2022
@XXMA16
Copy link
Contributor

XXMA16 commented May 29, 2023

Sinks.vc is not a discord.VoiceChannel, it is a discord.VoiceClient as shown in this example by adding a print(type(sink.vc)) under once_done.

@Lulalaby
Copy link
Member

Stay our of this pr. It's literally a year old lol.

@Pycord-Development Pycord-Development locked and limited conversation to collaborators May 29, 2023
@Lulalaby
Copy link
Member

Open an issue if that is still a problem. It might've changed over the time tho

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krittick krittick krittick approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@VincentRPS VincentRPS

Labels
feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@VincentRPS @XXMA16 @Lulalaby @krittick