Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do some typing in commands/context.py #848

Merged
merged 2 commits into from
Jan 28, 2022
Merged

fix: do some typing in commands/context.py #848

merged 2 commits into from
Jan 28, 2022

Conversation

1oonie
Copy link
Contributor

@1oonie 1oonie commented Jan 24, 2022

Summary

This PR just fixes some typing issues that I came across. (Specifically in commands/context.py)

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@VincentRPS VincentRPS added Merge normally priority: low Low Priority status: awaiting review Awaiting review from a maintainer labels Jan 26, 2022
@VincentRPS VincentRPS added this to the v2.0 milestone Jan 26, 2022
Lulalaby
Lulalaby previously approved these changes Jan 26, 2022
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (rebase) January 26, 2022 06:13
Dorukyum
Dorukyum reviewed Jan 28, 2022
View reviewed changes
discord/commands/context.py Outdated Show resolved Hide resolved
discord/commands/context.py Show resolved Hide resolved
auto-merge was automatically disabled January 28, 2022 09:57

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby merged commit 3eeeda9 into Pycord-Development:master Jan 28, 2022
@1oonie 1oonie removed their assignment Jan 29, 2022
@krittick
Copy link
Contributor

krittick commented Feb 2, 2022

Why did this revert the changes to author that were made in #464? This broke the typing that #464 fixed.

@krittick
Copy link
Contributor

krittick commented Feb 2, 2022

Specifically, this PR now causes this typing error which did not occur before the change:

image

@Lulalaby
Copy link
Member

Lulalaby commented Feb 2, 2022

wtf

@1oonie
Copy link
Contributor Author

1oonie commented Feb 2, 2022

Why are we using @cached_property anyway

@krittick krittick mentioned this pull request Feb 5, 2022
Merged
7 tasks
Lulalaby pushed a commit that referenced this pull request Feb 5, 2022
@krittick @Lulalaby
add (better) typing back to actx.author that was removed in #848
5b76c2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@1oonie @krittick @Lulalaby @Dorukyum @VincentRPS