Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Voice Recording #832

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Refactor Voice Recording #832

merged 3 commits into from
Jan 22, 2022

Conversation

VincentRPS
Copy link
Member

@VincentRPS VincentRPS commented Jan 22, 2022 •
edited
Loading

Summary

Should make the Voice Rec PR mergeable, by the standards asked within discord.

Custom Sinks are really the thing this PR does.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@VincentRPS VincentRPS self-assigned this Jan 22, 2022
@VincentRPS VincentRPS added the bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. label Jan 22, 2022
@Lulalaby Lulalaby merged commit 269114e into Pycord-Development:features/voice-receive Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

Assignees

@VincentRPS VincentRPS

Labels
bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentRPS @Lulalaby