Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python bytes, not Bytes just like the line above #75

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 2, 2021

Summary

https://docs.python.org/3/library/stdtypes.html#bytes
https://docs.python.org/3/library/stdtypes.html#binary-sequence-types-bytes-bytearray-memoryview

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Contributor

@jgayfer jgayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a lot of copy paste. For example, we don't have tests for pytest to execute.

@CodeWithSwastik
Copy link
Contributor

@FrostByte266 is already setting unittests and CI up.

@cclauss cclauss changed the title GitHub Action to lint Python code Python bytes, not Bytes just like the line above Sep 3, 2021
@cclauss
Copy link
Contributor Author

cclauss commented Sep 13, 2021

@CodeWithSwastik Your review, please.

@Middledot Middledot merged commit 91e0753 into Pycord-Development:master Sep 16, 2021
@cclauss cclauss deleted the patch-1 branch September 17, 2021 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants