Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make guild.audit_logs(limit) parameter optional #633

Merged
merged 1 commit into from
Dec 27, 2021

Conversation

r-hensley
Copy link
Contributor

@r-hensley r-hensley commented Dec 24, 2021

As written in the docs below the command:

limit: Optional[`int`]
            The number of entries to retrieve. If ``None`` retrieve all entries.

So the parameter should be Optional. Currently my IME returns the error Expected type 'int', got 'None' instead

Summary

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

As written in the docs below the command:

limit: Optional[`int`]
            The number of entries to retrieve. If ``None`` retrieve all entries.

So the parameter should be Optional. Currently my IME returns the error `Expected type 'int', got 'None' instead `
@Lulalaby Lulalaby merged commit 51dd856 into Pycord-Development:master Dec 27, 2021
@r-hensley r-hensley deleted the patch-1 branch February 28, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants