Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing documentation for get_application_context #59

Conversation

jgayfer
Copy link
Contributor

@jgayfer jgayfer commented Sep 1, 2021

Summary

We missed adding docs for one of this function's parameters.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@jgayfer jgayfer changed the title Add missing documentation for get_application_command Add missing documentation for get_application_context Sep 2, 2021
@CodeWithSwastik
Copy link
Contributor

Could you change the base branch of this PR to slash?

We missed adding docs for one of this function's parameters.
@jgayfer
Copy link
Contributor Author

jgayfer commented Sep 2, 2021

@CodeWithSwastik Not really. The method get_application_context is already in master, which is what this PR is adding docs for.

@jgayfer jgayfer changed the base branch from master to slash September 2, 2021 04:54
@jgayfer
Copy link
Contributor Author

jgayfer commented Sep 2, 2021

Oh it's up to date, I probably can 👍

@CodeWithSwastik
Copy link
Contributor

Thanks, we're adding changes to slash before merging them to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants