Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements a new get_or_fetch feature #42

Merged
merged 5 commits into from
Aug 31, 2021
Merged

Implements a new get_or_fetch feature #42

merged 5 commits into from
Aug 31, 2021

Conversation

xFGhoul
Copy link
Member

@xFGhoul xFGhoul commented Aug 31, 2021

Summary

Implements a new get_or_fetch feature

EX: member = await discord.utils.get_or_fetch(ctx.guild, 'member', 1234) # 1234 -> Member ID

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

CodeWithSwastik
CodeWithSwastik requested changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@CodeWithSwastik CodeWithSwastik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hasn't been implemented correctly, it doesn't check if getter is None when using get

@CodeWithSwastik CodeWithSwastik merged commit ea4b656 into Pycord-Development:master Aug 31, 2021
CodeWithSwastik added a commit that referenced this pull request Aug 31, 2021
@CodeWithSwastik
Revert "Implements a new get_or_fetch feature (#42)"
04ccc35 
This reverts commit ea4b656.
@CodeWithSwastik CodeWithSwastik mentioned this pull request Aug 31, 2021
Merged
CodeWithSwastik added a commit that referenced this pull request Aug 31, 2021
@CodeWithSwastik
Revert "Implements a new get_or_fetch feature (#42)" (#43)
cea77e2 
This reverts commit ea4b656.
@Revnoplex Revnoplex mentioned this pull request Apr 3, 2022
Closed
3 tasks
@ErikKalkoken ErikKalkoken mentioned this pull request May 20, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeWithSwastik CodeWithSwastik CodeWithSwastik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xFGhoul @CodeWithSwastik