Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for discord.User parsing #398

Merged
merged 8 commits into from
Dec 19, 2021
Merged

Fix for discord.User parsing #398

merged 8 commits into from
Dec 19, 2021

Conversation

Apocryphon-X
Copy link
Contributor

@Apocryphon-X Apocryphon-X commented Nov 4, 2021 •
edited
Loading

Summary

Closes #367.
Fix for parsing of discord.Member / discord.User when Slash Command is invoked from a DM.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

BobDotCom
BobDotCom previously requested changes Nov 5, 2021
View reviewed changes
discord/commands/commands.py Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 5, 2021 22:03

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Nov 9, 2021
Dorukyum
Dorukyum requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing ctx. prefixes on lines 538 and 543 creates NameErrors.

auto-merge was automatically disabled November 20, 2021 16:17

Head branch was pushed to by a user without write access

@Lulalaby
Copy link
Member

Lulalaby commented Dec 3, 2021

@Dorukyum

@krittick krittick mentioned this pull request Dec 13, 2021
Closed
@Dorukyum
Copy link
Member

Has this been extensively tested? Just to make sure.

@Lulalaby Lulalaby merged commit c25e2a2 into Pycord-Development:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Middledot Middledot Middledot approved these changes

@VincentRPS VincentRPS VincentRPS approved these changes

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees

@Apocryphon-X Apocryphon-X

Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

discord.User is not a valid input type for discord.commands.Option()
6 participants
@Apocryphon-X @Lulalaby @Dorukyum @BobDotCom @Middledot @VincentRPS