Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Send correct data to http.create_test_entitlement() #2595

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

lukenamop
Copy link
Contributor

@lukenamop lukenamop commented Oct 2, 2024

Summary

http.create_test_entitlement() asks for (application_id, payload). Previously, guild.create_test_entitlement() was sending (guild_id, payload) and user.create_test_entitlement() was sending (user_id, payload). I've fixed them to send the correct data.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: lukenamop <lukenamop@gmail.com>
Signed-off-by: lukenamop <lukenamop@gmail.com>
pre-commit-ci bot and others added 2 commits October 2, 2024 16:19
@lukenamop
Copy link
Contributor Author

create_test_entitlement is currently completely broken, the deadline for bots with paying customers to implement entitlements is coming up in 4 days (October 7). Would love for this fix to be implemented before then.

CHANGELOG.md Outdated Show resolved Hide resolved
lukenamop and others added 2 commits October 4, 2024 10:30
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: lukenamop <lukenamop@gmail.com>
Signed-off-by: lukenamop <lukenamop@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
@lukenamop
Copy link
Contributor Author

I've got my production bot running on this fork. Working as intended. Thanks for help with changelog formatting.

@plun1331 plun1331 enabled auto-merge (squash) October 4, 2024 20:39
@plun1331 plun1331 merged commit d7d3afb into Pycord-Development:master Oct 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants