Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext-pages): revert paginator on callback fail #2448

Merged
merged 3 commits into from
May 10, 2024
Merged

fix(ext-pages): revert paginator on callback fail #2448

merged 3 commits into from
May 10, 2024

Conversation

BobDotCom
Copy link
Member

@BobDotCom BobDotCom commented May 10, 2024 •
edited
Loading

Summary

Fixes #2447

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@BobDotCom BobDotCom added priority: low Low Priority ext.pages Relating to ext.pages labels May 10, 2024
@BobDotCom BobDotCom self-assigned this May 10, 2024
@BobDotCom BobDotCom requested a review from a team as a code owner May 10, 2024 21:30
@BobDotCom BobDotCom linked an issue May 10, 2024 that may be closed by this pull request
Paginator error upon failed interaction #2447
Closed
3 tasks
@BobDotCom BobDotCom enabled auto-merge (squash) May 10, 2024 21:44
@BobDotCom BobDotCom merged commit 6c990b9 into master May 10, 2024
53 checks passed
@Lulalaby Lulalaby deleted the 2447-paginator-error-upon-failed-interaction branch May 10, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@BobDotCom BobDotCom

Labels
ext.pages Relating to ext.pages priority: low Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paginator error upon failed interaction
2 participants
@BobDotCom @Lulalaby