-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext.pages): add more ways to send paginator by editing #2105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmLanke
changed the title
feat(ext.pages): add more ways to send via edit
feat(ext.pages): add more ways to send paginator via edit
Jun 8, 2023
OmLanke
changed the title
feat(ext.pages): add more ways to send paginator via edit
feat(ext.pages): add more ways to send paginator by editing
Jun 8, 2023
Lulalaby
changed the title
feat(ext.pages): add more ways to send paginator by editing
feat!(ext.pages): add more ways to send paginator by editing
Jun 8, 2023
Lulalaby
changed the title
feat!(ext.pages): add more ways to send paginator by editing
feat!: ext.pages: add more ways to send paginator by editing
Jun 8, 2023
On hold. There is parameter discrepancy between methods.
|
Should be good after #2138 is merged |
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
Lulalaby
previously approved these changes
Jun 25, 2023
JustaSqu1d
suggested changes
Jul 13, 2023
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
OmLanke
changed the title
feat(ext.pages)!: add more ways to send paginator by editing
feat(ext.pages): add more ways to send paginator by editing
Jul 14, 2023
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
JustaSqu1d
suggested changes
Jul 15, 2023
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
This was referenced Mar 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows the Paginator to be sent using the edit methods offered by
Interaction
,ApplicationContext
, andBridgeContext
.Also fixes #1877 by adding a new parameter
user
, when passing aMessage
object.paginator.edit()
didn't work at all, becausepaginator.user
was being set tomessage.author
. Butmessage.author
will always be the bot itself, since it can edit that message. This caused the views to not respond, unlessauthor_check
was disabled. This means a user would need be to be explicitly accepted while callingpaginator.edit()
, thus the new parameter.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.