Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong type hint Sink.vc #2090

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: wrong type hint Sink.vc #2090

merged 1 commit into from
May 30, 2023

Conversation

XXMA16
Copy link
Contributor

@XXMA16 XXMA16 commented May 29, 2023

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@XXMA16 XXMA16 requested a review from a team as a code owner May 29, 2023 15:07
@pullapprove4 pullapprove4 bot requested a review from WhoIsConch May 29, 2023 15:07
@pullapprove4 pullapprove4 bot requested a review from Lulalaby May 29, 2023 15:07
@Lulalaby Lulalaby requested review from plun1331 and VincentRPS and removed request for WhoIsConch May 29, 2023 15:15
@Lulalaby Lulalaby added the unconfirmed bug A bug report that needs triaging label May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #2090 (e54679c) into master (a3937f6) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2090   +/-   ##
=======================================
  Coverage   33.13%   33.13%           
=======================================
  Files          97       97           
  Lines       19136    19136           
=======================================
  Hits         6340     6340           
  Misses      12796    12796           
Flag Coverage Δ
macos-latest-3.10 33.11% <0.00%> (ø)
macos-latest-3.11 33.11% <0.00%> (ø)
macos-latest-3.8 33.12% <0.00%> (ø)
macos-latest-3.9 33.12% <0.00%> (ø)
ubuntu-latest-3.10 33.11% <0.00%> (ø)
ubuntu-latest-3.11 33.11% <0.00%> (ø)
ubuntu-latest-3.8 33.12% <0.00%> (ø)
ubuntu-latest-3.9 33.12% <0.00%> (ø)
windows-latest-3.10 33.11% <0.00%> (ø)
windows-latest-3.11 33.11% <0.00%> (ø)
windows-latest-3.8 33.12% <0.00%> (ø)
windows-latest-3.9 33.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/sinks/core.py 40.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3937f6...e54679c. Read the comment docs.

Copy link
Contributor

@EmmmaTech EmmmaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby enabled auto-merge (squash) May 30, 2023 14:20
@Lulalaby Lulalaby merged commit e3ee572 into Pycord-Development:master May 30, 2023
@XXMA16 XXMA16 deleted the typehint-fix branch August 19, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unconfirmed bug A bug report that needs triaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants