Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embeds having weird state #2071

Merged
merged 2 commits into from
May 12, 2023
Merged

fix: embeds having weird state #2071

merged 2 commits into from
May 12, 2023

Conversation

UP929312
Copy link
Contributor

Summary

Fixes previous embed commit

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: UP929312 <36114463+UP929312@users.noreply.github.com>
@UP929312 UP929312 requested a review from a team as a code owner May 12, 2023 20:48
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #2071 (b35f0d4) into master (2745344) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2071   +/-   ##
=======================================
  Coverage   33.22%   33.22%           
=======================================
  Files          97       97           
  Lines       19092    19092           
=======================================
  Hits         6343     6343           
  Misses      12749    12749           
Flag Coverage Δ
macos-latest-3.10 33.20% <0.00%> (ø)
macos-latest-3.11 33.20% <0.00%> (ø)
macos-latest-3.8 33.21% <0.00%> (ø)
macos-latest-3.9 33.21% <0.00%> (ø)
ubuntu-latest-3.10 33.20% <0.00%> (ø)
ubuntu-latest-3.11 33.20% <0.00%> (ø)
ubuntu-latest-3.8 33.21% <0.00%> (ø)
ubuntu-latest-3.9 33.21% <0.00%> (ø)
windows-latest-3.10 33.20% <0.00%> (ø)
windows-latest-3.11 33.20% <0.00%> (ø)
windows-latest-3.8 33.21% <0.00%> (ø)
windows-latest-3.9 33.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/embeds.py 25.21% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2745344...b35f0d4. Read the comment docs.

@Lulalaby Lulalaby changed the title FIX embeds having weird state fix: embeds having weird state May 12, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) May 12, 2023 21:09
@Lulalaby Lulalaby removed the request for review from Middledot May 12, 2023 21:09
@BobDotCom BobDotCom disabled auto-merge May 12, 2023 22:44
@BobDotCom BobDotCom enabled auto-merge (squash) May 12, 2023 22:44
@BobDotCom BobDotCom merged commit a20a6e8 into Pycord-Development:master May 12, 2023
@UP929312 UP929312 deleted the patch-8 branch May 13, 2023 10:00
@OmLanke OmLanke mentioned this pull request May 18, 2023
9 tasks
@pullapprove4
Copy link

pullapprove4 bot commented Jul 27, 2023

Please add a changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants