chore(i18n): change localization attributes' defaults (#1866) #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(i18n): make defaults for l10ns an empty dict * chore(changelog): add entry * fix(changlog): update entry oops * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * feat(i18n): None -> MISSING * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review adapt Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com> Signed-off-by: Middledot <78228142+Middledot@users.noreply.github.com> --------- Signed-off-by: Middledot <78228142+Middledot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com> Co-authored-by: Lala Sabathil <lala@pycord.dev>
pullapprove4
bot
requested review from
VincentRPS,
Lulalaby,
Dorukyum,
ChickenDevs,
plun1331,
FrostByte266,
WhoIsConch,
CodeWithSwastik and
BobDotCom
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2056 +/- ##
=======================================
Coverage 33.23% 33.24%
=======================================
Files 97 97
Lines 19038 19039 +1
=======================================
+ Hits 6328 6329 +1
Misses 12710 12710
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Lulalaby
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR to fix codeconv workflow
Summary
EDIT: This PR makes it so that l10n attrs are by default
MISSINGto be more API consistent.I'd call this a minor breaking change.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.