Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify defer's ephemeral arg #2053

Merged
merged 3 commits into from
May 7, 2023
Merged

docs: clarify defer's ephemeral arg #2053

merged 3 commits into from
May 7, 2023

Conversation

JustaSqu1d
Copy link
Member

@JustaSqu1d JustaSqu1d commented May 7, 2023

Summary

This should be something that can be clarified in the docs.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have NOT updated the changelog to include these changes.

@JustaSqu1d JustaSqu1d requested a review from a team as a code owner May 7, 2023 03:57
@JustaSqu1d JustaSqu1d added documentation Improvements or additions to documentation priority: low Low Priority status: awaiting review Awaiting review from a maintainer API Reflection Discords API wasn't correctly reflected in the lib labels May 7, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) May 7, 2023 10:16
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #2053 (51cf382) into master (bd28a34) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 51cf382 differs from pull request most recent head 1f23643. Consider uploading reports for the commit 1f23643 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2053   +/-   ##
=======================================
  Coverage   33.24%   33.24%           
=======================================
  Files          97       97           
  Lines       19036    19033    -3     
=======================================
  Hits         6328     6328           
+ Misses      12708    12705    -3     
Flag Coverage Δ
macos-latest-3.10 33.23% <ø> (+<0.01%) ⬆️
macos-latest-3.11 33.23% <ø> (+<0.01%) ⬆️
macos-latest-3.8 33.24% <ø> (+<0.01%) ⬆️
macos-latest-3.9 33.24% <ø> (+<0.01%) ⬆️
ubuntu-latest-3.10 33.23% <ø> (+<0.01%) ⬆️
ubuntu-latest-3.11 33.23% <ø> (+<0.01%) ⬆️
ubuntu-latest-3.8 33.24% <ø> (+<0.01%) ⬆️
ubuntu-latest-3.9 33.24% <ø> (+<0.01%) ⬆️
windows-latest-3.10 33.23% <ø> (+<0.01%) ⬆️
windows-latest-3.11 33.23% <ø> (+<0.01%) ⬆️
windows-latest-3.8 33.24% <ø> (+<0.01%) ⬆️
windows-latest-3.9 33.24% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/interactions.py 19.54% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd28a34...1f23643. Read the comment docs.

@Lulalaby Lulalaby merged commit ea95c35 into Pycord-Development:master May 7, 2023
@pullapprove4
Copy link

pullapprove4 bot commented Jul 27, 2023

Please add a changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib documentation Improvements or additions to documentation priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants