feat!: Add view.parent and store view.message on receiving Interaction for a component
#2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
OmLanke
changed the title
view._parent and store view.message on receiving Interaction for a componentview._parent and store view.message on receiving Interaction for a component
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2036 +/- ##
==========================================
- Coverage 33.25% 33.24% -0.02%
==========================================
Files 97 97
Lines 19027 19033 +6
==========================================
Hits 6328 6328
- Misses 12699 12705 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
JustaSqu1d
added
priority: medium
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
OmLanke
changed the title
view._parent and store view.message on receiving Interaction for a componentview.parent and store view.message on receiving Interaction for a component
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
Lulalaby
approved these changes
May 3, 2023
Lulalaby
requested review from
plun1331 and
BobDotCom
and removed request for
Middledot
plun1331
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a
view.parentattribute to store the original Interaction object the view was sent with.view.messageis now set when an Interaction for any component of the view is received.This saves the unnecessary call to
interaction.original_response(). The defaulton_timeoutmethod uses theeditmethods offered byMessage,InteractionMessageorInteraction(as added in #2026)Breaking change -
view.messageis not available on timeout if the view was sent usingInteractionResponse.send_message. Instead, use the methods offered byview.parent.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.