fix: attribute error with listeners in cogs #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1989 +/- ##
==========================================
- Coverage 33.34% 33.33% -0.01%
==========================================
Files 97 97
Lines 18894 18897 +3
==========================================
Hits 6300 6300
- Misses 12594 12597 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Lulalaby
previously approved these changes
Mar 28, 2023
auto-merge was automatically disabled
March 28, 2023 13:57
Head branch was pushed to by a user without write access
Lulalaby
previously approved these changes
Mar 28, 2023
BobDotCom
reviewed
Mar 28, 2023
auto-merge was automatically disabled
March 28, 2023 16:09
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
JustaSqu1d
added
bug
BobDotCom
reviewed
Mar 29, 2023
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
auto-merge was automatically disabled
March 29, 2023 13:05
Head branch was pushed to by a user without write access
Lulalaby
previously approved these changes
Mar 29, 2023
BobDotCom
reviewed
Mar 29, 2023
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
auto-merge was automatically disabled
March 29, 2023 13:44
Head branch was pushed to by a user without write access
|
Can this be merged now? |
Lulalaby
approved these changes
Mar 29, 2023
|
idk ask bob |
BobDotCom
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Attribute Error caused by #1957 when using listeners in cogs
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.