feat!: Client.on_error() improvement with new parameter #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited _run_event to pass the exception to on_error. Signed-off-by: Guard Boi <105892653+mariohero24@users.noreply.github.com>
Signed-off-by: Guard Boi <105892653+mariohero24@users.noreply.github.com>
Signed-off-by: Guard Boi <105892653+mariohero24@users.noreply.github.com>
Signed-off-by: Guard Boi <105892653+mariohero24@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Guard Boi <105892653+mariohero24@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1945 +/- ##
=======================================
Coverage 33.13% 33.13%
=======================================
Files 97 97
Lines 19136 19136
=======================================
Hits 6340 6340
Misses 12796 12796
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
guardboi
changed the title
plun1331
changed the title
|
This is a breaking change |
OmLanke
reviewed
Feb 26, 2023
didnt give me an error in testing, reverting Signed-off-by: Guard Boi <105892653+mariohero24@users.noreply.github.com>
Co-authored-by: Om <92863779+Om1609@users.noreply.github.com> Signed-off-by: Guard Boi <105892653+mariohero24@users.noreply.github.com>
Signed-off-by: Lala Sabathil <lala@pycord.dev>
Lulalaby
requested review from
Lulalaby,
BobDotCom and
Middledot
and removed request for
CodeWithSwastik
|
This pull request is in the In review step of the Default workflow. The following review teams are pending:
|
Lulalaby
approved these changes
May 30, 2023
|
Changelog entry is in the wrong section |
Fix it then :) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited _run_event to pass the exception to on_error.
Summary
in
client.py, line 381 has includedas excin order to pass an exception intoClient.on_error. This has also been changed in line 438 to 448, changing how the error is printed as well. This makes it easier to useon_errorwith this small change.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.