Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UnboundLocalError #1928

Merged
merged 7 commits into from
Feb 26, 2023
Merged

fix: UnboundLocalError #1928

merged 7 commits into from
Feb 26, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented Feb 16, 2023

Summary

Fixes the UnboundLocalError being raised for the br_cmd variable at line 133.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@OmLanke OmLanke requested a review from a team as a code owner February 16, 2023 15:52
@BobDotCom
Copy link
Member

Can you provide an example of some code that causes this error?

@OmLanke
Copy link
Contributor Author

OmLanke commented Feb 16, 2023

Can you provide an example of some code that causes this error?

I myself did not encounter this issue in my limited testing, but users have reported the error, and this change fixes it.

This also fixes a major oversight where br_cmd will not be defined at line 139.

@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner February 16, 2023 18:27
OmLanke and others added 2 commits February 20, 2023 23:32
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@BobDotCom BobDotCom enabled auto-merge (squash) February 22, 2023 15:26
@JustaSqu1d JustaSqu1d added changelog needed status: awaiting review Awaiting review from a maintainer labels Feb 25, 2023
@plun1331 plun1331 added the bug Something isn't working label Feb 26, 2023
@BobDotCom BobDotCom merged commit 34a23eb into Pycord-Development:master Feb 26, 2023
@OmLanke OmLanke deleted the patch-1 branch April 24, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog needed status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants