Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Typehinting arguments and variable for examples #1855

Merged
merged 3 commits into from
Jan 5, 2023
Merged

chore: Typehinting arguments and variable for examples #1855

merged 3 commits into from
Jan 5, 2023

Conversation

CringleySDays
Copy link
Contributor

Summary

Added typehinting to arguments and variables where needed for better practice

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@CringleySDays CringleySDays requested a review from a team as a code owner January 5, 2023 18:03
@CringleySDays CringleySDays changed the title Typehinting arguments and variable chore: Typehinting arguments and variable Jan 5, 2023
@Lulalaby Lulalaby changed the title chore: Typehinting arguments and variable examples: Typehinting arguments and variable Jan 5, 2023
@Lulalaby
Copy link
Member

Lulalaby commented Jan 5, 2023

update branch please

@Lulalaby Lulalaby changed the title examples: Typehinting arguments and variable chore: Typehinting arguments and variable Jan 5, 2023
@Lulalaby Lulalaby changed the title chore: Typehinting arguments and variable chore: Typehinting arguments and variable for examples Jan 5, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) January 5, 2023 18:20
@Lulalaby Lulalaby disabled auto-merge January 5, 2023 18:34
@Lulalaby Lulalaby merged commit c7e60d4 into Pycord-Development:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@BobDotCom BobDotCom BobDotCom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CringleySDays @Lulalaby @BobDotCom