Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to SlashCommand.mention using qualified_id #1672

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

NeloBlivion
Copy link
Member

Summary

Currently, mentions in groups are broken as subcommands do not have an ID. As such, qualified_id is implemented to return the parent ID and then implemented in mention.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

discord/commands/core.py Outdated Show resolved Hide resolved
NeloBlivion and others added 2 commits October 6, 2022 02:09
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@BobDotCom BobDotCom merged commit 47a058b into Pycord-Development:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants