Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw_mention utils #1658

Merged
merged 7 commits into from
Oct 2, 2022
Merged

Conversation

NeloBlivion
Copy link
Member

Summary

Reimplements the various raw_mentions properties from discord.Message under discord.utils. Message.raw_mentions can't be used with regular strings, which is an increasing use case with slash commands.

Also considering a followup commit for automatically converting them (e.g. resolve_mentions?) as counterparts to Message.mentions, Message.channel_mentions and Message.role_mentions but not sure where to implement. Possibly under Guild?

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

discord/utils.py Outdated Show resolved Hide resolved
@BobDotCom BobDotCom added status: in progress Work in Progess feature Implements a feature labels Oct 1, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) October 1, 2022 14:16
@BobDotCom BobDotCom added this to the v2.2 milestone Oct 1, 2022
BobDotCom
BobDotCom previously approved these changes Oct 1, 2022
BobDotCom
BobDotCom previously approved these changes Oct 2, 2022
BobDotCom
BobDotCom previously approved these changes Oct 2, 2022
ChickenDevs
ChickenDevs previously approved these changes Oct 2, 2022
@BobDotCom BobDotCom dismissed stale reviews from ChickenDevs and themself via d54a9e0 October 2, 2022 21:27
@BobDotCom BobDotCom merged commit 8764a0e into Pycord-Development:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature status: in progress Work in Progess
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants