Proxy webhooks and interactions #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: sync webhooks are not included in this PR. They aren't used by interactions, so therefore don't need to be passed the params from client like async webhooks. However, it might be deemed beneficial in the future to add these params to sync webhooks for parity. If this is desired, it can take place in a separate PR/Issue. |
BobDotCom
added
bug
ChickenDevs
previously approved these changes
Sep 30, 2022
Dorukyum
requested changes
Sep 30, 2022
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
BobDotCom
dismissed stale reviews from ChickenDevs and plun1331
via
faf2bd8
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
approved these changes
Sep 30, 2022
ChickenDevs
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates webhooks and interactions to support proxies.
Fixes #696
Information
Checklist
type: ignorecomments were used, a comment is also left explaining why.