Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Interaction.edit_original_message() InteractionMessage state #1565

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Fix Interaction.edit_original_message() InteractionMessage state #1565

merged 4 commits into from
Aug 23, 2022

Conversation

camelwater
Copy link
Contributor

Summary

Interaction.edit_original_message() returns an InteractionMessage, but it has a ConnectionState passed to the constructor instead of an InteractionMessageState.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@camelwater camelwater changed the title Fix Interaction.edit_original_message() message state Fix Interaction.edit_original_message() message state bug Aug 22, 2022
@camelwater camelwater changed the title Fix Interaction.edit_original_message() message state bug Fix Interaction.edit_original_message() InteractionMessage state Aug 22, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) August 22, 2022 19:34
@EmmmaTech
Copy link
Contributor

I don't see what the point of _InteractionMessageState is? All it is is a wrapper for ConnectionState

EmmmaTech
EmmmaTech approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@EmmmaTech EmmmaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my other comment is out of scope for this PR
Anyways LGTM

baronkobama
baronkobama approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@baronkobama baronkobama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby requested a review from Dorukyum August 23, 2022 19:43
@Lulalaby Lulalaby merged commit d74278f into Pycord-Development:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@EmmmaTech EmmmaTech EmmmaTech approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@baronkobama baronkobama baronkobama approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camelwater @EmmmaTech @Lulalaby @Dorukyum @baronkobama