Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New delete_message_seconds parameter #1557

Merged
merged 6 commits into from
Oct 1, 2022
Merged

New delete_message_seconds parameter #1557

merged 6 commits into from
Oct 1, 2022

Conversation

Middledot
Copy link
Member

Summary

The delete_message_days parameter is deprecated and replaced with delete_message_seconds.
discord-api-docs#5219

Shouldn't be merged until the docs get merged.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

BobDotCom
BobDotCom requested changes Aug 12, 2022
View reviewed changes
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Show resolved Hide resolved
Lulalaby
Lulalaby approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@plun1331 plun1331 added status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Aug 29, 2022
@plun1331
Copy link
Member

This is now officially documented - discord/discord-api-docs@7e3e3a3

@Middledot Middledot marked this pull request as ready for review October 1, 2022 00:48
@Middledot Middledot merged commit 5b4e067 into Pycord-Development:master Oct 1, 2022
@Middledot Middledot deleted the new-ban-dropped branch October 1, 2022 00:48
@BobDotCom BobDotCom added this to the v2.2 milestone Oct 1, 2022
@NeloBlivion NeloBlivion mentioned this pull request Oct 4, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@BobDotCom BobDotCom BobDotCom approved these changes

Assignees

@Middledot Middledot

Labels
feature Implements a feature status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: Done
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Middledot @plun1331 @Lulalaby @ChickenDevs @BobDotCom