Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct location of app_commands_badge flag #1553

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Correct location of app_commands_badge flag #1553

merged 6 commits into from
Aug 8, 2022

Conversation

Middledot
Copy link
Member

@Middledot Middledot commented Aug 7, 2022 •
edited
Loading

Summary

Moves app_commands_badge from SystemChannelFlags to ApplicationFlags . (#1535)

Reference: discord-api-docs#5222

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot
Add application command badge
61faf38
@Middledot
Add INVITES_DISABLED flag
77985bf
@Middledot
Revert INVITES_DISABLED flag
822c291 
this is it's own entire feature and should be in it's own PR when it's released
@Middledot Middledot added feature Implements a feature Merge with squash labels Aug 7, 2022
@Middledot Middledot enabled auto-merge (squash) August 7, 2022 17:52
Lulalaby
Lulalaby previously approved these changes Aug 7, 2022
View reviewed changes
@Lulalaby Lulalaby disabled auto-merge August 7, 2022 17:56
@Lulalaby Lulalaby enabled auto-merge (squash) August 7, 2022 17:56
@Middledot Middledot changed the title Add missing flag Add application_command_badge flag Aug 7, 2022
@Middledot Middledot disabled auto-merge August 7, 2022 18:44
@Middledot Middledot enabled auto-merge (squash) August 7, 2022 18:44
@Middledot
Copy link
Member Author

Updated auto-merge commit message

@Dorukyum
Copy link
Member

Dorukyum commented Aug 7, 2022

#1535 ?

@Middledot
Copy link
Member Author

Seems like it was added to the wrong class there

@Middledot Middledot changed the title Add application_command_badge flag Correct location of app_commands_badge flag Aug 7, 2022
@Middledot Middledot disabled auto-merge August 7, 2022 19:20
@Middledot Middledot enabled auto-merge (squash) August 7, 2022 19:20
plun1331
plun1331 previously approved these changes Aug 7, 2022
View reviewed changes
@lol219
Copy link
Contributor

lol219 commented Aug 7, 2022

Uh

Lulalaby
Lulalaby previously approved these changes Aug 7, 2022
View reviewed changes
lol219
lol219 reviewed Aug 7, 2022
View reviewed changes
Copy link
Contributor

@lol219 lol219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This shows up a badge in the bot's profile" ig

@Lulalaby
Copy link
Member

Lulalaby commented Aug 7, 2022

"This shows up a badge in the bot's profile" ig

Irrelevant.

And do me a favor, don't comment on prs with single words and so on.

It spams our logs

Lulalaby
Lulalaby reviewed Aug 7, 2022
View reviewed changes
discord/flags.py Outdated Show resolved Hide resolved
@Lulalaby Lulalaby dismissed stale reviews from plun1331 and themself via 6d6c901 August 7, 2022 20:15
Lulalaby
Lulalaby approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed wording and incorrect information.

@Middledot Middledot merged commit db38261 into Pycord-Development:master Aug 8, 2022
@Middledot Middledot deleted the missing-flag-n-feature branch August 8, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lol219 lol219 lol219 left review comments

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
feature Implements a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Middledot @Dorukyum @lol219 @Lulalaby @plun1331