Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues in options.py #1473

Merged
merged 16 commits into from
Jul 13, 2022

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Jul 6, 2022

Summary

Creates a new type for allowed input types and updates option type parsing to remove all type issues.
The option type should be added to the documentation and we should make sure it's not missing any type.
Also the parsing should be tested for all cases. Done

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Dorukyum Dorukyum changed the title Typehint input_type Fix type issues in opt Jul 7, 2022
@Dorukyum Dorukyum changed the title Fix type issues in opt Fix type issues in options.py Jul 7, 2022
@Dorukyum
Copy link
Member Author

Dorukyum commented Jul 7, 2022

So I decided to expand the PR just a little bit and fix every single type issue in this file (there were like 46 after InputType)
Any contribution is appreciated!

@Dorukyum Dorukyum self-assigned this Jul 7, 2022
@Dorukyum Dorukyum marked this pull request as ready for review July 7, 2022 09:10
@Dorukyum
Copy link
Member Author

Dorukyum commented Jul 8, 2022

Tested and added to documentation.

Lulalaby
Lulalaby previously approved these changes Jul 8, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) July 8, 2022 20:44
plun1331
plun1331 previously approved these changes Jul 11, 2022
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
@Lulalaby Lulalaby dismissed stale reviews from plun1331 and themself via 6dc8a9b July 12, 2022 18:32
@Lulalaby Lulalaby requested a review from Middledot July 12, 2022 18:32
Lulalaby
Lulalaby previously approved these changes Jul 12, 2022
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
@Lulalaby Lulalaby merged commit 751242b into Pycord-Development:master Jul 13, 2022
@Dorukyum Dorukyum deleted the inputtype-type branch January 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation needed priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants