Add message property to views #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronkobama
previously approved these changes
Jun 27, 2022
|
Woops. Had that there from debugging. Thanks! |
Lulalaby
added
Merge with squash
priority: medium
Lulalaby
previously approved these changes
Jun 27, 2022
Dorukyum
reviewed
Jun 28, 2022
Dorukyum
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is to give views a new
messageproperty for after a message is sent with the view attached. This makes it easier for users to manipulate the view with no interaction, such as in the on_timeout function.Checklist
type: ignorecomments were used, a comment is also left explaining why