Resolve issues with discord.Thread and discord.ThreadOption when used in discord.Option
#1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
previously approved these changes
Jun 16, 2022
|
This PR may not be necessary since ThreadOption exists, however, there does appear to be an issue with ThreadOption and I may convert this PR into resolving that since it is closely related. |
|
I've decided to patch the issue with ThreadOption but keep the changes in this PR as they will allow for discord.Thread to be used directly as an input type now, avoiding confusion. This does make ThreadOption effectively useless, but removing it would be considered a breaking change and I think we're too close to 2.0.0 full release to have breaking changes now. |
plun1331
reviewed
Jun 17, 2022
baronkobama
changed the title
discord.Thread not working as discord.Option input typediscord.Thread and discord.ThreadOption when used in discord.Option
Dorukyum
previously approved these changes
Jun 22, 2022
Dorukyum
approved these changes
Jun 23, 2022
Lulalaby
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves issues when using
discord.Threadas adiscord.Optioninput type. Previously, doing so raised an error:TypeError: 'NoneType' object is not callable. Now, threads are correctly handled when given as an option type. A few touchups to changes made in #1365 are also made here including comment updates and updates to how the_invoke_flagkey works when being added to data. Atop of this,discord.ThreadOptionnow has documentation with this PR.Checklist
type: ignorecomments were used, a comment is also left explaining why