Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks creating forum posts #1405

Merged
merged 6 commits into from
Jun 25, 2022

Conversation

Middledot
Copy link
Member

Summary

discord-api-docs#5007
Allows webhooks to create new threads in their forum channel with

await hook.send("## Important Stuff", name="Important Announcement")

I'm not too sure about this design though. Maybe something like hook.create_thread could be done instead?

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Middledot Middledot added the feature Implements a feature label Jun 9, 2022
@Lulalaby
Copy link
Member

Lulalaby commented Jun 9, 2022

Create forum post would sound better. Otherwise it could lead to confusion

@Dorukyum
Copy link
Member

I think we should call this parameter thread_name, that should remove the confusion and reflect the API.

@Lulalaby
Copy link
Member

Correct

@Middledot
Copy link
Member Author

So it shoud be thread_name?

discord/webhook/async_.py Outdated Show resolved Hide resolved
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
discord/webhook/sync.py Outdated Show resolved Hide resolved
@Middledot Middledot enabled auto-merge (squash) June 25, 2022 16:50
@Middledot Middledot merged commit 3c2fb0f into Pycord-Development:master Jun 25, 2022
@Middledot Middledot deleted the webhooks-forums branch June 26, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants