Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BridgeExtContext.delete() method #1348

Merged

Conversation

baronkobama
Copy link
Contributor

@baronkobama baronkobama commented May 12, 2022

Summary

This PR attempts to add a BridgeExtContext.delete() method. The method itself only tries to delete if a response has been made and currently doesn't raise an exception if a response has not been made.

The ApplicationContext.delete() method now has new documentation and allows for the delay parameter.

Closes #1343

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

EmmmaTech
EmmmaTech previously approved these changes May 12, 2022
discord/ext/bridge/context.py Outdated Show resolved Hide resolved
discord/ext/commands/context.py Outdated Show resolved Hide resolved
@baronkobama baronkobama changed the title Add Context.delete() method Add BridgeExtContext.delete() method May 13, 2022
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change for consistency

discord/commands/context.py Outdated Show resolved Hide resolved
@Dorukyum Dorukyum enabled auto-merge (squash) May 13, 2022 15:33
@Dorukyum Dorukyum merged commit 8b42c46 into Pycord-Development:master May 13, 2022
@baronkobama baronkobama deleted the improve-context-deletes branch May 30, 2022 03:53
@baronkobama baronkobama restored the improve-context-deletes branch May 30, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ext.bridge] 'BridgeExtContext' object has no attribute 'delete'
5 participants