Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_activity_invite shortcut method #128

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

CodeWithSwastik
Copy link
Contributor

@CodeWithSwastik CodeWithSwastik commented Sep 7, 2021

Summary

Adds a discord.VoiceChannel.create_activity_invite shortcut method to aid creating party game invites like youtube together etc.

Rationale

await vc.create_activity_invite('youtube')

would be easier to use and readable compared to

await vc.create_invite(target_type=discord.InviteTarget.embedded_application, target_application_id=755600276941176913)

P.S. Documentation can be improved.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Luc1412
Copy link
Contributor

Luc1412 commented Sep 7, 2021

I think the term "activity" might be better than "party". Also, an enum could be more convenient instead of using a String.

@CodeWithSwastik
Copy link
Contributor Author

We already have enums for activities which could be confusing. Though I like create_activity_invite over create_party_invite

@CodeWithSwastik CodeWithSwastik changed the title Add create_party_invite shortcut method Add create_activity_invite shortcut method Sep 8, 2021
@CodeWithSwastik CodeWithSwastik merged commit f7378fb into Pycord-Development:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants