Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Interaction.to_dict #1274

Merged
merged 5 commits into from
May 13, 2022
Merged

Implement Interaction.to_dict #1274

merged 5 commits into from
May 13, 2022

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Apr 17, 2022 •
edited
Loading

Summary

This attempts to add the feature suggested in #155.
The current implementation has the following problems:

  • the user field is not complete
  • the message field is missing
  • the member field is missing

Open for contribution.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added this to the v2.0 milestone Apr 17, 2022
@krittick krittick added feature request New feature request feature Implements a feature labels Apr 17, 2022
@UP929312
Copy link
Contributor

So glad the old issues/feature requests are getting some love

@Lulalaby Lulalaby added the priority: medium Medium Priority label Apr 26, 2022
@Dorukyum Dorukyum marked this pull request as ready for review May 13, 2022 18:27
@Dorukyum Dorukyum enabled auto-merge (squash) May 13, 2022 18:27
@Dorukyum Dorukyum added status: awaiting review Awaiting review from a maintainer and removed feature request New feature request labels May 13, 2022
@Dorukyum Dorukyum self-assigned this May 13, 2022
@Lulalaby Lulalaby disabled auto-merge May 13, 2022 20:53
@Lulalaby Lulalaby merged commit 711576a into Pycord-Development:master May 13, 2022
@Middledot Middledot linked an issue May 13, 2022 that may be closed by this pull request
Add support for interaction.to_dict() #155
Closed
@Dorukyum Dorukyum deleted the interaction.to_dict branch January 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krittick krittick krittick approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@Dorukyum Dorukyum

Labels
feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add support for interaction.to_dict()
4 participants
@Dorukyum @UP929312 @krittick @Lulalaby