Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in voice #1231

Merged
merged 4 commits into from
Apr 8, 2022
Merged

Text in voice #1231

merged 4 commits into from
Apr 8, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Implement text in voice - the ability to send messages to voice channels.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Apr 5, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Apr 5, 2022
@BobDotCom BobDotCom self-assigned this Apr 5, 2022
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not only implement text in voice.

This PR is out of scope with the additional changes and therefore a bad example.

Considering split of pr

@BobDotCom
Copy link
Member Author

This does not only implement text in voice.

This PR is out of scope with the additional changes and therefore a bad example.

Considering split of pr

It does though....? There's no changes besides text-in-voice.

@EmmmaTech
Copy link
Contributor

I'm confused about this: how do you even send text messages in Voice Channels?
Oh wait does Discord now bundle "Text Channels" with Voice Channels?

@Lulalaby
Copy link
Member

Lulalaby commented Apr 5, 2022

I'm confused about this: how do you even send text messages in Voice Channels?
Oh wait does Discord now bundle "Text Channels" with Voice Channels?

Voice channel just have a API side lock. They are basically text channel since a while

@Lulalaby
Copy link
Member

Lulalaby commented Apr 5, 2022

This does not only implement text in voice.

This PR is out of scope with the additional changes and therefore a bad example.

Considering split of pr

It does though....? There's no changes besides text-in-voice.

I see changes in the deletion strategy

@BobDotCom
Copy link
Member Author

This does not only implement text in voice.
This PR is out of scope with the additional changes and therefore a bad example.
Considering split of pr

It does though....? There's no changes besides text-in-voice.

I see changes in the deletion strategy

No changes, I threw code into a helper method to be re-used.

@Lulalaby
Copy link
Member

Lulalaby commented Apr 5, 2022

Oh okay. Then LGTM

Lulalaby
Lulalaby previously approved these changes Apr 5, 2022
@BobDotCom BobDotCom enabled auto-merge April 5, 2022 20:53
@BobDotCom BobDotCom merged commit 8d52bc8 into master Apr 8, 2022
@Lulalaby Lulalaby deleted the text-in-voice branch June 9, 2022 08:09
@NeloBlivion NeloBlivion mentioned this pull request Feb 22, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants