-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text in voice #1231
Text in voice #1231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not only implement text in voice.
This PR is out of scope with the additional changes and therefore a bad example.
Considering split of pr
It does though....? There's no changes besides text-in-voice. |
I'm confused about this: how do you even send text messages in Voice Channels? |
Voice channel just have a API side lock. They are basically text channel since a while |
I see changes in the deletion strategy |
No changes, I threw code into a helper method to be re-used. |
Oh okay. Then LGTM |
Summary
Implement text in voice - the ability to send messages to voice channels.
Checklist
type: ignore
comments were used, a comment is also left explaining why