Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reloading application command callbacks #1186

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

Dorukyum
Copy link
Member

Summary

Fixes #1037 by modifying ApplicationCommand.__eq__ which is used when identifying reloaded commands.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum self-assigned this Mar 20, 2022
@Dorukyum Dorukyum added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Mar 20, 2022
@Dorukyum Dorukyum requested a review from krittick March 20, 2022 14:00
@BobDotCom BobDotCom merged commit 2c1dbe1 into Pycord-Development:master Mar 21, 2022
@Dorukyum Dorukyum deleted the fix-slash-reload branch January 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Slash command callbacks do not reload
2 participants