Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Command Localization #1185

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Implement Command Localization #1185

merged 1 commit into from
Mar 22, 2022

Conversation

BobDotCom
Copy link
Member

@BobDotCom BobDotCom commented Mar 19, 2022 •
edited
Loading

Summary

Implements command localization.

Documentation: discord/discord-api-docs#4653

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom added this to the v2.0 milestone Mar 19, 2022
@BobDotCom BobDotCom self-assigned this Mar 19, 2022
@BobDotCom BobDotCom added status: awaiting review Awaiting review from a maintainer Merge with squash labels Mar 19, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) March 19, 2022 23:40
@BobDotCom
Copy link
Member Author

An example for this would be nice

Dorukyum
Dorukyum approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example can be added later, this seems to be ready for merging

@BobDotCom BobDotCom requested review from a team and FrostByte266 and removed request for a team March 21, 2022 17:05
@BobDotCom BobDotCom merged commit 1cf9dd0 into master Mar 22, 2022
@Lulalaby Lulalaby deleted the localization branch June 9, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@krittick krittick Awaiting requested review from krittick

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266 FrostByte266 is a code owner automatically assigned from Pycord-Development/maintainers

Assignees

@BobDotCom BobDotCom

Labels
status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BobDotCom @Dorukyum @ChickenDevs