Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modal.on_error #1167

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Add Modal.on_error #1167

merged 2 commits into from
Mar 17, 2022

Conversation

Dorukyum
Copy link
Member

Summary

One of the plans in #1001.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Mar 12, 2022
@Dorukyum Dorukyum requested a review from krittick March 12, 2022 16:10
@Dorukyum Dorukyum self-assigned this Mar 12, 2022
plun1331
plun1331 reviewed Mar 14, 2022
View reviewed changes
discord/ui/modal.py Outdated Show resolved Hide resolved
@krittick krittick enabled auto-merge (squash) March 17, 2022 09:18
@krittick krittick added this to the v2.0 milestone Mar 17, 2022
@krittick krittick merged commit ceb23a5 into Pycord-Development:master Mar 17, 2022
@Dorukyum Dorukyum deleted the modal.on_error branch January 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@krittick krittick krittick approved these changes

@Middledot Middledot Middledot approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

Assignees

@Dorukyum Dorukyum

Labels
feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Dorukyum @krittick @plun1331 @Middledot