Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InteractionResponse.edit_message in Modal Interactions #1165

Merged
merged 1 commit into from
Mar 11, 2022
Merged

InteractionResponse.edit_message in Modal Interactions #1165

merged 1 commit into from
Mar 11, 2022

Conversation

Ombucha
Copy link
Contributor

@Ombucha Ombucha commented Mar 11, 2022 •
edited
Loading

Summary

Fix #1058

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

krittick
krittick approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@krittick krittick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@EmmmaTech
Copy link
Contributor

I would recommend changing the title & description of this PR so people can get a rough idea of what this PR is for.

@Ombucha Ombucha changed the title Fix #1058 InteractionResponse.edit_message in Modal Interactions Mar 11, 2022
@Ombucha
Copy link
Contributor Author

Ombucha commented Mar 11, 2022

I would recommend changing the title & description of this PR so people can get a rough idea of what this PR is for.

Is it fine now?

EmmmaTech
EmmmaTech approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@EmmmaTech EmmmaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmmaTech
Copy link
Contributor

I would recommend changing the title & description of this PR so people can get a rough idea of what this PR is for.

Is it fine now?

Yup.

@Ombucha
Copy link
Contributor Author

Ombucha commented Mar 11, 2022 •
edited
Loading

Can someone merge this?

@Dorukyum Dorukyum merged commit 5caf788 into Pycord-Development:master Mar 11, 2022
@Ombucha Ombucha deleted the patch-1 branch March 11, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krittick krittick krittick approved these changes

@EmmmaTech EmmmaTech EmmmaTech approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interaction.response.edit_message Does Not Work in the discord.ui.Modal Class
4 participants
@Ombucha @EmmmaTech @krittick @Dorukyum