Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove methods for image and thumbnail in embeds #111

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Add remove methods for image and thumbnail in embeds #111

merged 2 commits into from
Sep 6, 2021

Conversation

izxxr
Copy link
Contributor

@izxxr izxxr commented Sep 5, 2021

Summary

This PR adds two new methods to Embed:

  • remove_image to remove the image of the embed.
  • remove_thumbnail to remove the thumbnail of the embed.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@jgayfer
Copy link
Contributor

jgayfer commented Sep 5, 2021

Would love some more insight into why these changes are desired.

@izxxr
Copy link
Contributor Author

izxxr commented Sep 6, 2021

Would love some more insight into why these changes are desired.

It was discussed in #development yesterday. The current way of removing an image or thumbnail from the embed is like:

embed.set_image(url=Embed.Empty)

(Same for thumbnail), This is kind of vague and not very intuitive.

It would be nice to have methods to remove them easily. Besides, remove_author and remove_footer exist too. So, It'd be consistent.

@Dorukyum Dorukyum merged commit 8aa1e90 into Pycord-Development:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants