Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the example of /channel #1054

Closed
wants to merge 3 commits into from
Closed

Change the example of /channel #1054

wants to merge 3 commits into from

Conversation

jontobonto
Copy link

@jontobonto jontobonto commented Feb 19, 2022

Summary

When using squared bracket in discord.Option, you get an error because you can't use a list since in the source it is checking for a tuple. So to reflect this, I changed the example to round brackets.

It fixes an unclear piece of code in the examples. No effect on the library code itself.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

When using squared bracket in discord.Option, you get an error because you can't use a list since in the source it is checking for a tuple. So to reflect this, I changed the example to round brackets.
@plun1331
Copy link
Member

This was discussed in #1000 already

@jontobonto
Copy link
Author

@plun1331 Oh, my bad, hope that it's fine anyways

Copy link
Contributor

@ThatGenZGamer48 ThatGenZGamer48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot a comma between the tuple end and the starting of Select a channel.

@jontobonto
Copy link
Author

Oh, yea, my bad. But now everything should be fine.

Co-authored-by: Icebluewolf <44532864+Icebluewolf@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants