Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set force to default true (registration rewrite 2) #1024

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Set force to default true (registration rewrite 2) #1024

merged 5 commits into from
Feb 16, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Defaults force kwarg in command registration to true, using a bulk update by default.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with squash labels Feb 15, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Feb 15, 2022
@BobDotCom BobDotCom self-assigned this Feb 15, 2022
@BobDotCom BobDotCom enabled auto-merge (squash) February 15, 2022 18:57
plun1331
plun1331 reviewed Feb 15, 2022
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar/spelling errors

discord/bot.py Outdated Show resolved Hide resolved
discord/bot.py Outdated Show resolved Hide resolved
discord/bot.py Outdated Show resolved Hide resolved
discord/bot.py Outdated Show resolved Hide resolved
BobDotCom and others added 4 commits February 15, 2022 20:45
@BobDotCom @plun1331
Update discord/bot.py
7061d27 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@BobDotCom @plun1331
Update discord/bot.py
3ca3ca8 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@BobDotCom @plun1331
Update discord/bot.py
00fea1d 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@BobDotCom @plun1331
Update discord/bot.py
0b1c90f 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Lulalaby
Lulalaby approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BobDotCom BobDotCom merged commit 3d098a8 into Pycord-Development:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Middledot approved these changes

@krittick krittick Awaiting requested review from krittick

Assignees

@BobDotCom BobDotCom

Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BobDotCom @Lulalaby @plun1331 @Middledot