Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DataLoader.persistent_workers warnings in ddp_spawn #6762

Merged
merged 13 commits into from
Apr 9, 2021
Merged

Update DataLoader.persistent_workers warnings in ddp_spawn #6762

merged 13 commits into from
Apr 9, 2021

Conversation

s-rog
Copy link
Contributor

@s-rog s-rog commented Mar 31, 2021 •
edited
Loading

What does this PR do?

Update dataloader warnings with ddp_spawn in accordance with pytorch API changes.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Mar 31, 2021 •
edited
Loading

Hello @s-rog! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-09 00:50:22 UTC

@s-rog
Copy link
Contributor Author

s-rog commented Mar 31, 2021

cc @tchaton
I updated the other warnings as well to make them consistent, let me know what you think

@s-rog s-rog self-assigned this Mar 31, 2021
@s-rog s-rog added the data handling Generic data-related topic label Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021 •
edited
Loading

Codecov Report

Merging #6762 (511f962) into master (01b9cf8) will decrease coverage by 7%.
The diff coverage is 50%.

❗ Current head 511f962 differs from pull request most recent head afd0adf. Consider uploading reports for the commit afd0adf to get more accurate results

@@           Coverage Diff            @@
##           master   #6762     +/-   ##
========================================
- Coverage      91%     84%     -7%     
========================================
  Files         193     193             
  Lines       12299   13107    +808     
========================================
- Hits        11252   11025    -227     
- Misses       1047    2082   +1035

@s-rog s-rog marked this pull request as ready for review April 3, 2021 04:03
@s-rog
Copy link
Contributor Author

s-rog commented Apr 6, 2021 •
edited
Loading

oh man... this master merge is botched....

Edit: a rebase and force push seems to have fixed it...

Edit: Our GPU tests seem to be running only in 1.6, hence the missed coverage

@s-rog s-rog force-pushed the dataloader_warn branch from 0b90bff to 97411f2 Compare April 6, 2021 01:36
@s-rog s-rog added this to the 1.2.x milestone Apr 6, 2021
tchaton
tchaton approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition ! Some failing tests.

@s-rog s-rog requested a review from kaushikb11 as a code owner April 9, 2021 00:50
carmocca
carmocca approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test to cover all 4 warnings. LGTM!

@carmocca carmocca enabled auto-merge (squash) April 9, 2021 00:52
@carmocca carmocca changed the title Update dataloader warnings Update DataLoader.persistent_workers warnings in ddp_spawn Apr 9, 2021
@carmocca carmocca added ready PRs ready to be merged docs Documentation related data handling Generic data-related topic and removed data handling Generic data-related topic labels Apr 9, 2021
@carmocca carmocca modified the milestones: 1.2.x, 1.3 Apr 9, 2021
@carmocca carmocca merged commit e35192d into master Apr 9, 2021
@carmocca carmocca deleted the dataloader_warn branch April 9, 2021 09:38
@carmocca
Copy link
Contributor

carmocca commented Apr 9, 2021 •
edited
Loading

Unfortunately, this got auto-merged with Windows tests failing. Can you have a look @s-rog?

Fixed in #6930

@carmocca carmocca mentioned this pull request Apr 9, 2021
Merged
11 tasks
@Borda
Copy link
Member

Borda commented Apr 9, 2021

@carmocca @tchaton this breaks most of our tests and all Windows!

@Borda Borda mentioned this pull request Apr 9, 2021
Merged
11 tasks
@tchaton
Copy link
Contributor

tchaton commented Apr 9, 2021

nd all Windows!

How comes this wasn't been blocked then ?

@awaelchli awaelchli mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@s-rog s-rog

Labels
data handling Generic data-related topic docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@s-rog @pep8speaks @carmocca @Borda @tchaton @justusschock